Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 )
Change subject: IMPALA-6429: Fix decimal division ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9114/3/be/src/util/decimal-util.h File be/src/util/decimal-util.h: http://gerrit.cloudera.org:8080/#/c/9114/3/be/src/util/decimal-util.h@58 PS3, Line 58: return MultiplyByScale(v, t.scale, false, nullptr); > SFINAE is why it compiled. Slight correction - I think it's even simpler than that - the template never even got instantiated. Please make sure that all the be tests still compile - some of them were doing weird things and creating their own ColumnTypes iirc. -- To view, visit http://gerrit.cloudera.org:8080/9114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd1075d9c78986cd975dd29c1125d71ba6560c23 Gerrit-Change-Number: 9114 Gerrit-PatchSet: 3 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Thu, 01 Feb 2018 19:02:46 +0000 Gerrit-HasComments: Yes
