Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 )
Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront ...................................................................... Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/8707/20/be/src/runtime/io/request-context.cc File be/src/runtime/io/request-context.cc: http://gerrit.cloudera.org:8080/#/c/8707/20/be/src/runtime/io/request-context.cc@174 PS20, Line 174: > Right, the range won't be scheduled, because it needs to move to 'next_scan thanks for the explanation. http://gerrit.cloudera.org:8080/#/c/8707/20/be/src/runtime/io/request-context.cc@179 PS20, Line 179: WriteRange* write_range = static_cast<WriteRange*>(range); > Updated the comment. makes sense -- To view, visit http://gerrit.cloudera.org:8080/8707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia243bf8b62feeea602b122e0503ea4ba7d3ee70f Gerrit-Change-Number: 8707 Gerrit-PatchSet: 21 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 02 Feb 2018 01:19:58 +0000 Gerrit-HasComments: Yes
