Tianyi Wang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9198


Change subject: IMPALA-3916: Reserve SQL:2016 reserved words
......................................................................

IMPALA-3916: Reserve SQL:2016 reserved words

This patch reserves SQL:2016 reserved words, excluding:
1. Impala builtin function names.
2. Time unit words(year, month, etc.).
3. An exception list based on a discussion.

Some test cases are modified to avoid these words. A impalad and
catalogd startup option reserved_words_version is added. The words are
reserved if the option is set to "3.0.0".

Change-Id: If1b295e6a77e840cf1b794c2eb73e1b9d2b8ddd6
Reviewed-on: http://gerrit.cloudera.org:8080/9096
Reviewed-by: Alex Behm <alex.b...@cloudera.com>
Reviewed-by: Philip Zeyliger <phi...@cloudera.com>
Tested-by: Impala Public Jenkins
(cherry picked from commit f0b3d9d122f2c6eb4137bf93e3512a489ff8fab0)

The default value of the flag is changed to "2.11.0" in 2.x so that no
unused reservation is made.

Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8
---
M be/src/common/global-flags.cc
M be/src/common/init.cc
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/Db.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java
M fe/src/test/java/org/apache/impala/planner/StatsExtrapolationTest.java
M fe/src/test/java/org/apache/impala/service/JdbcTest.java
M testdata/workloads/functional-query/queries/QueryTest/empty-build-joins.test
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
M testdata/workloads/functional-query/queries/QueryTest/partition-col-types.test
M testdata/workloads/functional-query/queries/QueryTest/single-node-nlj.test
M testdata/workloads/functional-query/queries/QueryTest/spilling-large-rows.test
M testdata/workloads/functional-query/queries/QueryTest/values.test
A tests/custom_cluster/test_reserved_words_version.py
M tests/custom_cluster/test_stats_extrapolation.py
M tests/query_test/test_sort.py
28 files changed, 570 insertions(+), 442 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/9198/1
--
To view, visit http://gerrit.cloudera.org:8080/9198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd29d6aebe793d4eb37c092c1364f3acfebd91f8
Gerrit-Change-Number: 9198
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>

Reply via email to