Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9158 )
Change subject: IMPALA-6449: Use CLOCK_MONOTONIC in ConditionVariable ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9158/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9158/1//COMMIT_MSG@13 PS1, Line 13: CLOCK_MONOTONIC > Reading the man pages, it basically says that even CLOCK_MONOTONIC can be a Thanks for doing the research. I believe CLOCK_MONOTONIC_RAW is only available after Linux kernel 2.6.28 so CLOCK_MONOTONIC seems more widely available. https://www.systutorials.com/docs/linux/man/2-clock_settime/ FWIW, our monotonic stopwatch is also using CLOCK_MONOTONIC. The monotonicity of the clock is the major point here. I agree that CLOCK_MONOTONIC_RAW would be even better but we may need to do more work to detect whether it's available on the platform. -- To view, visit http://gerrit.cloudera.org:8080/9158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81611cfd5e7c5347203fe7fa6b0f615602257f87 Gerrit-Change-Number: 9158 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 02 Feb 2018 23:09:44 +0000 Gerrit-HasComments: Yes
