Zach Amsden has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9192 )

Change subject: IMPALA-6204: Remove external DataSource
......................................................................


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/9192/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9192/4//COMMIT_MSG@23
PS4, Line 23:   CAUSED BY: UnsupportedOperationException: Eternal Data source 
table not supported.
Eternal Data source?


http://gerrit.cloudera.org:8080/#/c/9192/4//COMMIT_MSG@27
PS4, Line 27: For the most part, I deleted the unused code. In a few places, a 
renamed
I renamed


http://gerrit.cloudera.org:8080/#/c/9192/4/common/thrift/CatalogObjects.thrift
File common/thrift/CatalogObjects.thrift:

http://gerrit.cloudera.org:8080/#/c/9192/4/common/thrift/CatalogObjects.thrift@38
PS4, Line 38:   DEPRECATED_DATA_SOURCE, // removed in Impala 3.0
I'm not sure I see the point of keeping this around instead of just totally 
deleting it.


http://gerrit.cloudera.org:8080/#/c/9192/4/common/thrift/CatalogObjects.thrift@48
PS4, Line 48:   DEPRECATED_DATA_SOURCE_TABLE, // removed in Impala 3.0
Same comment.


http://gerrit.cloudera.org:8080/#/c/9192/4/common/thrift/PlanNodes.thrift
File common/thrift/PlanNodes.thrift:

http://gerrit.cloudera.org:8080/#/c/9192/4/common/thrift/PlanNodes.thrift@43
PS4, Line 43:   DEPRECATED_DATA_SOURCE_NODE, // removed in Impala 3.0
Again, why do we need this?



--
To view, visit http://gerrit.cloudera.org:8080/9192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02a3a6740466ed7372b71d948c705b30886dcfb6
Gerrit-Change-Number: 9192
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Feb 2018 19:01:33 +0000
Gerrit-HasComments: Yes

Reply via email to