Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9218 )
Change subject: IMPALA-6473: Fix analytic fn that partitions and orders on same expr ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9218/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/9218/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@342 PS1, Line 342: // If the expr is in the 'partition by' and already in 'sortExprs', but also in minor suggestion: Exprs that appear in both PARTITION BY and ORDER BY only need to be added to the 'sortExprs' once. http://gerrit.cloudera.org:8080/#/c/9218/1/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test File testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test: http://gerrit.cloudera.org:8080/#/c/9218/1/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test@2086 PS1, Line 2086: # IMPALA-6473: analytic fn where the same expr is in the 'partition by' and the 'order by' Since the bug was in the planner, please make this a planner test. -- To view, visit http://gerrit.cloudera.org:8080/9218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5f1d5fbc6f69df5850f96afed345ce27668c30b Gerrit-Change-Number: 9218 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Comment-Date: Mon, 05 Feb 2018 22:36:55 +0000 Gerrit-HasComments: Yes
