Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 )
Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/9223/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9223/5//COMMIT_MSG@23 PS5, Line 23: . run end-to-end tests as well. see testdata/workloads/functional-query/queries/QueryTest/parquet-filtering.test. this is used by tests/query_test/test_mt_dop.py http://gerrit.cloudera.org:8080/#/c/9223/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/9223/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@230 PS5, Line 230: dictionary what's the "dictionary" prefix for? seems this is still just for min/max conjuncts (minMaxConjuncts_) and not for dictionaryFilterConjuncts_. http://gerrit.cloudera.org:8080/#/c/9223/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1100 PS5, Line 1100: Dictionary make this name consistent with member name if updated. -- To view, visit http://gerrit.cloudera.org:8080/9223 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d55ab6a1ae551867a9f68b3622844102cc854e Gerrit-Change-Number: 9223 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Feb 2018 19:27:47 +0000 Gerrit-HasComments: Yes
