Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9241 )
Change subject: IMPALA-6077: remove Parquet BIT_PACKED def level support ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9241/2/testdata/workloads/functional-query/queries/QueryTest/parquet-def-levels.test File testdata/workloads/functional-query/queries/QueryTest/parquet-def-levels.test: http://gerrit.cloudera.org:8080/#/c/9241/2/testdata/workloads/functional-query/queries/QueryTest/parquet-def-levels.test@55 PS2, Line 55: # IMPALA-6077: unsupported BIT_PACKED encoding fails when materializing columns. : select count(id), count(tinyint_col), count(smallint_col), count(int_col), : count(bigint_col), count(float_col), count(double_col), count(date_string_col), : count(string_col), count(timestamp_col), count(year), count(month), count(day) : from alltypesagg_bitpacked This query seems to be the same as the next query, and should not materialize columns. http://gerrit.cloudera.org:8080/#/c/9241/2/testdata/workloads/functional-query/queries/QueryTest/parquet-def-levels.test@64 PS2, Line 64: materializing I am not 100% sure about this, but I think that if a column is not complex, and the stats are filled, then count can be served from column chunk stats without reading any data page, so this error will not be returned. This may not be a problem for this specific parquet file, but I would mention it in a comment, or replace the query with something that has to read the data pages. http://gerrit.cloudera.org:8080/#/c/9241/2/testdata/workloads/functional-query/queries/QueryTest/parquet-def-levels.test@65 PS2, Line 65: select count(id), count(tinyint_col), count(smallint_col), count(int_col), : count(bigint_col), count(float_col), count(double_col), count(date_string_col), : count(string_col), count(timestamp_col), count(year), count(month), count(day) Is it necessary to list every column here? If one column is enough for the test, then I would prefer if it were shorter (for the sake of readability). -- To view, visit http://gerrit.cloudera.org:8080/9241 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12c75b7f162dd7de8e26cf31be142b692e3624ae Gerrit-Change-Number: 9241 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Fri, 09 Feb 2018 14:58:23 +0000 Gerrit-HasComments: Yes
