Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 )
Change subject: IMPALA-5440 Add planner tests with extreme statistics values ...................................................................... Patch Set 13: Code-Review+1 (2 comments) minor comments, otherwise lgtm. alex, pls have a look. http://gerrit.cloudera.org:8080/#/c/9065/13/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: http://gerrit.cloudera.org:8080/#/c/9065/13/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java@783 PS13, Line 783: This function plans query, which is the request that estimated : * cardinality is calculated based on, extracts the cardinalities : * from plan nodes and fails if the cardinality is not within the : * specified bounds [min, max]. easier: Plans 'query' and fails if estimated cardinalities are not within the specified bounds [min, max]. http://gerrit.cloudera.org:8080/#/c/9065/13/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java@805 PS13, Line 805: (node.estimated_stats == null) { : f nit: spacing -- To view, visit http://gerrit.cloudera.org:8080/9065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86dec47cf1438882cafaec53e97864ccfcdff3cb Gerrit-Change-Number: 9065 Gerrit-PatchSet: 13 Gerrit-Owner: Xinran Tinney <xyutin...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Xinran Tinney <xyutin...@cloudera.com> Gerrit-Comment-Date: Fri, 09 Feb 2018 19:01:11 +0000 Gerrit-HasComments: Yes
