Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9173 )

Change subject: IMPALA-3271: organise and warn on removed startup flags
......................................................................

IMPALA-3271: organise and warn on removed startup flags

Gather all the removed flags in a single place and establish consistent
behaviour.

If the flag is set, a warning is logged. GFlags are initialised before
logging, so the warning goes to stderr instead of the WARNING log.

The affected flags are:
be_service_threads, cgroup_hierarchy_path, enable_accept_queue_server,
enable_partitioned_aggregation, enable_partitioned_hash_join,
enable_phj_probe_side_filtering, enable_rm, llama_addresses,
llama_callback_port, llama_host, llama_max_request_attempts,
llama_port, llama_registration_timeout_secs,
llama_registration_wait_secs, local_nodemanager_url,
resource_broker_cnxn_attempts, resource_broker_cnxn_retry_interval_ms,
resource_broker_recv_timeout, resource_broker_send_timeout,
rm_always_use_defaults, rm_default_cpu_vcores, rm_default_memory,
rpc_cnxn_attempts, rpc_cnxn_retry_interval_ms, staging_cgroup,
suppress_unknown_disk_id_warnings, use_statestore,

Testing:
Ran "start-impala-cluster.py --impalad_args=--enable_rm=true"
and verified that the warning appeared in
logs/cluster/impalad-error.log

Cherry-picks: not for 2.x

Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Reviewed-on: http://gerrit.cloudera.org:8080/9173
Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/common/global-flags.cc
M be/src/exec/exec-node.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/rpc/thrift-server.cc
M be/src/runtime/exec-env.cc
M be/src/scheduling/query-schedule.cc
M be/src/service/impala-server.cc
M be/src/service/impalad-main.cc
9 files changed, 54 insertions(+), 47 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9bb4792e1b18840aa85aa5d755a09f2b5461f34
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>

Reply via email to