Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 )
Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/8363/5/be/src/util/sharded-query-map-util.h File be/src/util/sharded-query-map-util.h: http://gerrit.cloudera.org:8080/#/c/8363/5/be/src/util/sharded-query-map-util.h@36 PS5, Line 36: > doesn't that have to be NUM_QUERY_BUCKETS? otherwise, QueryIdToBucket() doe Yes, I've made the change to have everything encapsulated within these classes. http://gerrit.cloudera.org:8080/#/c/8363/5/be/src/util/sharded-query-map-util.h@61 PS5, Line 61: > This comment would become moot once you encode the number of shards. then t Done http://gerrit.cloudera.org:8080/#/c/8363/5/be/src/util/sharded-query-map-util.h@61 PS5, Line 61: > how about 'container_array' to make it clear this must be an array? Done http://gerrit.cloudera.org:8080/#/c/8363/5/be/src/util/sharded-query-map-util.h@63 PS5, Line 63: NUM_QUERY_BUCKE > like above, given this is a function of the number of shards, it should be Done -- To view, visit http://gerrit.cloudera.org:8080/8363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I61089090e1095da45a8a64ed3ccc78bd310807f1 Gerrit-Change-Number: 8363 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 09 Feb 2018 22:18:41 +0000 Gerrit-HasComments: Yes
