Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9202 )

Change subject: IMPALA-6396: Exchange node's memory usage should include its 
receiver's
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9202/4/be/src/runtime/data-stream-mgr.cc
File be/src/runtime/data-stream-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/9202/4/be/src/runtime/data-stream-mgr.cc@82
PS4, Line 82:   DCHECK(profile != nullptr);
> nit: I think we usually switch files from NULL to nullptr on the first occu
Yes, I tried to keep the scope of the change to be smaller. I converted this 
one to make it at least consistent within a function.


http://gerrit.cloudera.org:8080/#/c/9202/4/be/src/runtime/krpc-data-stream-mgr.h
File be/src/runtime/krpc-data-stream-mgr.h:

http://gerrit.cloudera.org:8080/#/c/9202/4/be/src/runtime/krpc-data-stream-mgr.h@241
PS4, Line 241:   /// Ownership of the receiver is shared between this 
DataStream mgr instance and the
> could you document what parent_tracker should be?
Done



--
To view, visit http://gerrit.cloudera.org:8080/9202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ca3c47d87bfcd221d34565eda1878f3c15d5c45
Gerrit-Change-Number: 9202
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Feb 2018 22:31:24 +0000
Gerrit-HasComments: Yes

Reply via email to