Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 )
Change subject: IMPALA-5717: Support for ORC data files ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9134/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9134/3//COMMIT_MSG@15 PS3, Line 15: Instead of linking the orc-reader as a third party library, it's > Which version or commit hash of ORC did you import? The version is 1.2.3. It's a little old since we started the Impala-ORC project one year ago. I can update it to the latest version if you think it's essential. As for using it as a third-party library, I also concern about the memory paradigm gap between the ORC lib and Impala. On the other hand, I can try to reduce the size of this patch, e.g. remove useless codes like ColumnPrinter, reuse as more Impala codes as possible e.g. RLE decoders, int128. My goal can be making this reader no more complex than parquet column readers. If finally you still decide to add it to the native-toolchain project, could you give me some docs of how to submit code review for that project? Is it just the same as Impala? http://gerrit.cloudera.org:8080/#/c/9134/3//COMMIT_MSG@25 PS3, Line 25: tests. > We should also add ORC for TPC-H and TPC-DS so that we have some larger dat Sure, actually we have tested them but I forget to add this in the patch. -- To view, visit http://gerrit.cloudera.org:8080/9134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b6ae4ce3b9ee8125b21993702faa87537790a4 Gerrit-Change-Number: 9134 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 10 Feb 2018 00:34:49 +0000 Gerrit-HasComments: Yes
