Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 )
Change subject: IMPALA-6497: add "Last row fetched" and AC events ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9271/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/9271/2/be/src/runtime/coordinator.cc@865 PS2, Line 865: returned_all_results_ = true; > should'nt "Last row fetched" come directly after this? Good point. I changed it and updated the test so that it checked the order of the events, not just their existence. -- To view, visit http://gerrit.cloudera.org:8080/9271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32a707e4660061e75c86ad967f1fac6f6737da7e Gerrit-Change-Number: 9271 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 12 Feb 2018 19:33:30 +0000 Gerrit-HasComments: Yes
