Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9287 )
Change subject: IMPALA-6269: Cherry-pick dependency change for KRPC ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9287/1/be/src/kudu/rpc/acceptor_pool.h File be/src/kudu/rpc/acceptor_pool.h: http://gerrit.cloudera.org:8080/#/c/9287/1/be/src/kudu/rpc/acceptor_pool.h@20 PS1, Line 20: > The original patch had #include <stdint.h> here. Is it not necessary someho Kudu uses include-what-you-use and it complains about the missing include for int64_t. Should I add it here, too? -- To view, visit http://gerrit.cloudera.org:8080/9287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bda390ea92cceb0d696767402c978a83b386825 Gerrit-Change-Number: 9287 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 13 Feb 2018 01:59:14 +0000 Gerrit-HasComments: Yes
