Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9291 )

Change subject: IMPALA-6508: add KRPC test flag
......................................................................


Patch Set 5:

(2 comments)

> This means we will have automated test runs with both krpc enabled and 
> disabled for the foreseeable future

I'm convinced, then. Thanks.

http://gerrit.cloudera.org:8080/#/c/9291/5/tests/common/custom_cluster_test_suite.py
File tests/common/custom_cluster_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/9291/5/tests/common/custom_cluster_test_suite.py@137
PS5, Line 137:     if pytest.config.option.test_krpc:
             :       cmd.append("--impalad_args=-use_krpc")
> I'm not sure I understand what you mean. Should they use $TEST_START_CLUSTE
I just meant that if someone performs a private build with their own 
TEST_START_CLUSTER_ARGS, then the TEST_START_CLUSTER_ARGS will not be applied 
in custom cluster tests. This is something I noticed while poking around in the 
code. You don't have to fix that in this patch.


http://gerrit.cloudera.org:8080/#/c/9291/5/tests/custom_cluster/test_krpc_mem_usage.py
File tests/custom_cluster/test_krpc_mem_usage.py:

http://gerrit.cloudera.org:8080/#/c/9291/5/tests/custom_cluster/test_krpc_mem_usage.py@77
PS5, Line 77:   
@CustomClusterTestSuite.with_args("--stress_datastream_recvr_delay_ms=1000")
> I'll reply on the change itself.
Done



--
To view, visit http://gerrit.cloudera.org:8080/9291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie01a5de2afac4a0f43d5fceff283f6108ad6a3ab
Gerrit-Change-Number: 9291
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Feb 2018 17:34:41 +0000
Gerrit-HasComments: Yes

Reply via email to