Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9310 )
Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize lsb_release output from RHEL OS ...................................................................... Patch Set 1: (1 comment) I think the RHEL part of this is fine. I'd prefer you not truncate the Ubuntu versions, since there's genuine ambiguity there. http://gerrit.cloudera.org:8080/#/c/9310/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/9310/1/bin/bootstrap_toolchain.py@63 PS1, Line 63: "ubuntu12" : "ec2-package-ubuntu-12-04", This is problematic. Ubuntu has a 12.10 and 14.10 and 16.10 release per https://wiki.ubuntu.com/Releases. They're not "Long Term Support", but we want to be unambiguous here. -- To view, visit http://gerrit.cloudera.org:8080/9310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6 Gerrit-Change-Number: 9310 Gerrit-PatchSet: 1 Gerrit-Owner: Vincent Tran <vtt...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Tue, 13 Feb 2018 23:30:19 +0000 Gerrit-HasComments: Yes
