Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 )
Change subject: IMPALA-6497: add "Last row fetched" and AC events ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/9271/5/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/9271/5/tests/query_test/test_observability.py@206 PS5, Line 206: event_regexes = [r'Fragment Instance Lifecycle Event Timeline', > I figured it was a convention to use raw strings for regexes in python. I t That makes sense, thanks for the explanation. http://gerrit.cloudera.org:8080/#/c/9271/5/tests/query_test/test_observability.py@209 PS5, Line 209: r'First Batch Sent', > Nice catch. IMPALA-6511 has been fixed so this list should now include "Open Finished" after "Prepare Finished". -- To view, visit http://gerrit.cloudera.org:8080/9271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32a707e4660061e75c86ad967f1fac6f6737da7e Gerrit-Change-Number: 9271 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 14 Feb 2018 00:05:24 +0000 Gerrit-HasComments: Yes