Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9191 )
Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment ...................................................................... IMPALA-5269: Fix issue with final line of query followed by a comment The patch is to remove any comments in a statement when checking if a statement ends with a semicolon delimiter. For example: Before (semicolon delimiter is needed at the end): select 1 + 1; -- comment\n; After (semicolon delimiter is no longer needed): select 1 + 1; -- comment Testing: - Ran end-to-end tests in shell Change-Id: I54f9a8f65214023520eaa010fc462a663d02d258 Reviewed-on: http://gerrit.cloudera.org:8080/9191 Reviewed-by: Fredy Wijaya <[email protected]> Reviewed-by: Taras Bobrovytsky <[email protected]> Tested-by: Impala Public Jenkins --- M shell/impala_shell.py M tests/shell/test_shell_interactive.py 2 files changed, 43 insertions(+), 0 deletions(-) Approvals: Fredy Wijaya: Looks good to me, but someone else must approve Taras Bobrovytsky: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I54f9a8f65214023520eaa010fc462a663d02d258 Gerrit-Change-Number: 9191 Gerrit-PatchSet: 9 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
