Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9250 )
Change subject: IMPALA-6519: API to allocate unreserved buffer ...................................................................... IMPALA-6519: API to allocate unreserved buffer The motivation is to allow allocation of buffers without reservation in ExchangeNode. Currently this it not possible because IncreaseReservationToFit() followed by AllocateBuffer() is non-atomic. We need to handle concurrent allocations in ExchangeNode because there may be multiple batches being received at a given time. This is a temporary solution until we can implement proper reservations in ExchangeNode (IMPALA-6524). Testing: Added basic unit test. Change-Id: Ia4d17b3db25491f796484de22405fbdee7a0f983 Reviewed-on: http://gerrit.cloudera.org:8080/9250 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/runtime/bufferpool/buffer-pool-internal.h M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/bufferpool/buffer-pool.h M be/src/runtime/bufferpool/reservation-tracker.cc M be/src/runtime/bufferpool/reservation-tracker.h 6 files changed, 131 insertions(+), 33 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia4d17b3db25491f796484de22405fbdee7a0f983 Gerrit-Change-Number: 9250 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
