Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 )
Change subject: IMPALA-6508: add KRPC test flag ...................................................................... Patch Set 9: (3 comments) Thanks for the reviews, please see PS9. http://gerrit.cloudera.org:8080/#/c/9291/5/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/9291/5/tests/common/custom_cluster_test_suite.py@137 PS5, Line 137: if use_exclusive_coordinators: : cmd.append("--use_exclusive_coordinato > Not sure I'm totally following (haven't really looked much at the custom cl Thanks for the feedback here and on the dev@ list. I added a comment to clarify that we ignore TEST_START_CLUSTER_ARGS on purpose here. http://gerrit.cloudera.org:8080/#/c/9291/8/tests/custom_cluster/test_exchange_delays.py File tests/custom_cluster/test_exchange_delays.py: http://gerrit.cloudera.org:8080/#/c/9291/8/tests/custom_cluster/test_exchange_delays.py@31 PS8, Line 31: @SkipIfBuildType.n > May want to remove it now that the fix for IMPALA-6512 is being merged. Done http://gerrit.cloudera.org:8080/#/c/9291/8/tests/custom_cluster/test_krpc_mem_usage.py File tests/custom_cluster/test_krpc_mem_usage.py: http://gerrit.cloudera.org:8080/#/c/9291/8/tests/custom_cluster/test_krpc_mem_usage.py@64 PS8, Line 64: > If this applies to all the tests here (it appears to), then I think SkipIf Done -- To view, visit http://gerrit.cloudera.org:8080/9291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie01a5de2afac4a0f43d5fceff283f6108ad6a3ab Gerrit-Change-Number: 9291 Gerrit-PatchSet: 9 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Feb 2018 22:05:09 +0000 Gerrit-HasComments: Yes
