Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9352
Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled() ...................................................................... IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled() There are cancellation checks in HDFS scanner code that are using ScannerContext::cancelled(), however, if an internal cancellation happens then RuntimeState::is_cancelled() should also be checked to detect these. As a solution I extended ScannerContext::cancelled() to check RuntimeState::is_cancelled() as well. Creating automatic tests for this is difficult as the result of the query is actually the same with and without this change. With manual tests I verifyed that in case an internal cancel happens (I made the exchange node fail during a select query) this change prevents CommitRows() being executed multiple times even if the query had been cancelled before the first call. Change-Id: I3eb960d9d6f2dde4b2cb4988aa06288d11802b9a --- M be/src/exec/scanner-context.cc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/9352/1 -- To view, visit http://gerrit.cloudera.org:8080/9352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3eb960d9d6f2dde4b2cb4988aa06288d11802b9a Gerrit-Change-Number: 9352 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com>
