Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9306 )

Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9306/2/be/src/exec/kudu-util.cc
File be/src/exec/kudu-util.cc:

http://gerrit.cloudera.org:8080/#/c/9306/2/be/src/exec/kudu-util.cc@214
PS2, Line 214:
> Yeah, I just took what the formatter suggested. Will update.
Done


http://gerrit.cloudera.org:8080/#/c/9306/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java:

http://gerrit.cloudera.org:8080/#/c/9306/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@625
PS2, Line 625:     for (TupleId tupleId: targetSlotsByTid.keySet()) {
> I filed IMPALA-6533. Can you reference that here?
Done



--
To view, visit http://gerrit.cloudera.org:8080/9306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f927fce25dc4fa9529a4e0b688825699f5c0ea6
Gerrit-Change-Number: 9306
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Comment-Date: Fri, 16 Feb 2018 16:22:45 +0000
Gerrit-HasComments: Yes

Reply via email to