Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 )
Change subject: IMPALA-5152: Introduce metadata loading phase ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/8958/4/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/8958/4/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@302 PS4, Line 302: Map of all query-relevant tables that is populated before analysis in : // Frontend#requestTableLoadAndWait(). : // An entry in the map is guaranteed to point to a loaded table. This could mean : // the table was loaded successfully or a load was attempted but failed. : // The absence of an entry indicates that table was not in the Catalog at the time : // t > nit: is most of the detail for this comment better stated in the StmtTableC Condensed comment. http://gerrit.cloudera.org:8080/#/c/8958/4/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java File fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/8958/4/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@43 PS4, Line 43: v > nit: sp Done http://gerrit.cloudera.org:8080/#/c/8958/4/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@46 PS4, Line 46: Frontend.class > use this class. Oops. Done. http://gerrit.cloudera.org:8080/#/c/8958/4/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@62 PS4, Line 62: numCatalogUpdates_ > unclear from the name what numCatalogUpdates_ tracks. how about: numLoadsRe In my mind these are two completely different things, so I'd prefer not to use the same "load" terminology for them. I modified the var names to distinguish between sent/received and added comments. http://gerrit.cloudera.org:8080/#/c/8958/4/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@115 PS4, Line 115: * Collects and loads all tables and views required to analyze the given statement > nit: period Done -- To view, visit http://gerrit.cloudera.org:8080/8958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68d32d5acd4a6f6bc6cedb05e6cc5cf604d24a55 Gerrit-Change-Number: 8958 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 16 Feb 2018 18:00:13 +0000 Gerrit-HasComments: Yes
