Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 )
Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront ...................................................................... Patch Set 28: Code-Review+2 (5 comments) http://gerrit.cloudera.org:8080/#/c/8707/28/be/src/runtime/io/disk-io-mgr.h File be/src/runtime/io/disk-io-mgr.h: http://gerrit.cloudera.org:8080/#/c/8707/28/be/src/runtime/io/disk-io-mgr.h@81 PS28, Line 81: /// 2. GetNextRange(): returns to the caller the next scan range it should process. it'd be good to mention the StartScanRange() alternative path. http://gerrit.cloudera.org:8080/#/c/8707/26/be/src/runtime/io/disk-io-mgr.h File be/src/runtime/io/disk-io-mgr.h: http://gerrit.cloudera.org:8080/#/c/8707/26/be/src/runtime/io/disk-io-mgr.h@290 PS26, Line 290: ge can be sc > I feel like this name is pretty vague - I wonder if we should call it GetNe That seems like an improvement to me. Up to you if you want to incorporate that in this diff. http://gerrit.cloudera.org:8080/#/c/8707/28/be/src/runtime/io/request-context.h File be/src/runtime/io/request-context.h: http://gerrit.cloudera.org:8080/#/c/8707/28/be/src/runtime/io/request-context.h@50 PS28, Line 50: AllocateBuffers Do you mean AllocateBuffersForRange() or AddUnusedBuffers()? http://gerrit.cloudera.org:8080/#/c/8707/25/be/src/runtime/io/request-context.cc File be/src/runtime/io/request-context.cc: http://gerrit.cloudera.org:8080/#/c/8707/25/be/src/runtime/io/request-context.cc@160 PS25, Line 160: ScanRange* scan_range = static_cast<ScanRange*>(range); > Do you mean because it sort-of implies that it's a terminal state? We could I guess it's okay. http://gerrit.cloudera.org:8080/#/c/8707/28/be/src/runtime/io/scan-range.cc File be/src/runtime/io/scan-range.cc: http://gerrit.cloudera.org:8080/#/c/8707/28/be/src/runtime/io/scan-range.cc@104 PS28, Line 104: returned I was hoping we could get rid of that, but oh well. -- To view, visit http://gerrit.cloudera.org:8080/8707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia243bf8b62feeea602b122e0503ea4ba7d3ee70f Gerrit-Change-Number: 8707 Gerrit-PatchSet: 28 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sun, 18 Feb 2018 22:50:58 +0000 Gerrit-HasComments: Yes
