Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 )
Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool ...................................................................... Patch Set 17: Rebased and fixed a couple of bugs with reservation calculations that I found running tpch_nested at scale. Bug 1: Rounded up instead of down with RoundUpToPowerOfTwo(reservation_to_distribute), leading to reservation being incorrectly distributed between columns. Added backend test to repro. Bug 2: Didn't reserve memory for columns in nested collections. Added planner tests to directly check this. -- To view, visit http://gerrit.cloudera.org:8080/8966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic09c6196b31e55b301df45cc56d0b72cfece6786 Gerrit-Change-Number: 8966 Gerrit-PatchSet: 17 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 19 Feb 2018 20:50:13 +0000 Gerrit-HasComments: No
