Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9344 )

Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from 
BufferPool
......................................................................


Patch Set 7: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9344/6/be/src/runtime/row-batch.cc
File be/src/runtime/row-batch.cc:

http://gerrit.cloudera.org:8080/#/c/9344/6/be/src/runtime/row-batch.cc@193
PS6, Line 193:   row_batch->tuple_ptrs_info_->client = client;
> We rely on tuple_ptrs_info_ being set to distinguish where tuple_ptrs_ is a
Ah I see, I follow now.


http://gerrit.cloudera.org:8080/#/c/9344/7/be/src/runtime/row-batch.cc
File be/src/runtime/row-batch.cc:

http://gerrit.cloudera.org:8080/#/c/9344/7/be/src/runtime/row-batch.cc@206
PS7, Line 206:   row_batch->num_rows_ = header.num_rows();
We're expecting that capacity_ == header.num_rows() here, right? Can we add a 
DCHECK



--
To view, visit http://gerrit.cloudera.org:8080/9344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4b1a45f68b9df0d3b539511e15aff15700246f2
Gerrit-Change-Number: 9344
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Feb 2018 21:09:40 +0000
Gerrit-HasComments: Yes

Reply via email to