Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9063 )

Change subject: IMPALA-5801: Clean up codegen GetType() interface
......................................................................


Patch Set 9: Code-Review+2

(2 comments)

This seems like an improvement. Thanks for doing the cleanup. Will start the 
merge once Gabor +1s.

http://gerrit.cloudera.org:8080/#/c/9063/9/be/src/codegen/llvm-codegen.h
File be/src/codegen/llvm-codegen.h:

http://gerrit.cloudera.org:8080/#/c/9063/9/be/src/codegen/llvm-codegen.h@270
PS9, Line 270: site
nit: side?


http://gerrit.cloudera.org:8080/#/c/9063/9/be/src/exec/hdfs-scanner.cc
File be/src/exec/hdfs-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/9063/9/be/src/exec/hdfs-scanner.cc@333
PS9, Line 333:   llvm::PointerType* uint8_ptr_type = codegen->i8_ptr_type();
Thanks for this cleanup



--
To view, visit http://gerrit.cloudera.org:8080/9063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib146ca21af82023b0b460f813eae3435b4b2eb77
Gerrit-Change-Number: 9063
Gerrit-PatchSet: 9
Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Feb 2018 23:38:52 +0000
Gerrit-HasComments: Yes

Reply via email to