Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9292 )

Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage
......................................................................


Patch Set 15: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9292/8/be/src/rpc/rpc-mgr.cc
File be/src/rpc/rpc-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/9292/8/be/src/rpc/rpc-mgr.cc@128
PS8, Line 128: rviceIf* service_p
> That's true. Non-generated services don't necessarily use a map to lookup m
Ok thanks for the explanation. We can address it when it becomes necessary. 
This looks good for now.


http://gerrit.cloudera.org:8080/#/c/9292/14/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/9292/14/tests/webserver/test_web_pages.py@251
PS14, Line 251:
> I factored the name into a parameter to make the code more generic. The nex
Makes sense, the query can be a parameter too then (like a 2-D array). But lets 
defer that for the future.



--
To view, visit http://gerrit.cloudera.org:8080/9292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7af7c1a84a5be82c979ca4ef1edf35167493be3f
Gerrit-Change-Number: 9292
Gerrit-PatchSet: 15
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Feb 2018 01:48:27 +0000
Gerrit-HasComments: Yes

Reply via email to