John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9275 )
Change subject: IMPALA-6499: [DOCS] Fixed formatting errors in split_part function ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml@1079 PS4, Line 1079: <codeblock> Don't indent the <codeblock> line. http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml@1102 PS4, Line 1102: <p> : These examples show what happens for out-of-range field : positions. Specifying a value less than 1 produces an error. : Specifying a value greater than the number of fields returns a : zero-length string (which is not the same as : <codeph>NULL</codeph>). : </p> Put back some extra leading spaces to keep the indentation the same as it was originally. http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml@1126 PS4, Line 1126: <p> This whole paragraph lost several spaces of indentation. Please keep the same indentation as in the original. http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml@1128 PS4, Line 1128: value:</p><codeblock><![CDATA[ This is still all on one line when it should be on 3: - The text "value:" - The </p> - The <codeblock><![CDATA[ line http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml@1161 PS4, Line 1161: </dd> It looks like a blank line was removed from here by accident. Let's keep it, to avoid cherry-picking glitches. -- To view, visit http://gerrit.cloudera.org:8080/9275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a Gerrit-Change-Number: 9275 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Feb 2018 21:27:53 +0000 Gerrit-HasComments: Yes