Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9360 )
Change subject: [security] test and fixes for TLS socket EINTR issues ...................................................................... [security] test and fixes for TLS socket EINTR issues SSL_{read,write}() can return SSL_ERROR_WANT_{READ,WRITE} correspondingly when signal interrupts recv()/send() calls even if SSL_MODE_AUTO_RETRY is set in the TLS context. To handle that properly in Socket::Blocking{Recv,Write}() methods, return NetworkError() with appropriate POSIX error code from TlsSocket::{Recv,Write}(). As a by-product, this changelist fixes flakiness in TestUniqueClientIds scenario of the ClientStressTest test and other flaky tests which failed with errors like below: Bad status: IO error: Could not connect to the cluster: \ Client connection negotiation failed: client connection to \ IP:port: Read zero bytes on a blocking Recv() call: \ Transferred 0 of 4 bytes Prior to this fix, the test failure ratio observed with dist-test for TSAN builds was about 6% in multiple 1K runs. After the fix, no failures observed. Change-Id: Ibec9049186f79f1c43295e4735538ed7ba4e516e Reviewed-on: http://gerrit.cloudera.org:8080/8462 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert <danburk...@apache.org> Reviewed-by: Alexey Serbin <aser...@cloudera.com> Reviewed-on: http://gerrit.cloudera.org:8080/9360 Reviewed-by: Sailesh Mukil <sail...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/kudu/security/CMakeLists.txt M be/src/kudu/security/tls_handshake.cc M be/src/kudu/security/tls_socket.cc M be/src/kudu/util/net/socket.cc A security/tls_socket-test.cc 5 files changed, 227 insertions(+), 7 deletions(-) Approvals: Sailesh Mukil: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibec9049186f79f1c43295e4735538ed7ba4e516e Gerrit-Change-Number: 9360 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>