Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 )
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf' ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8854/4/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/8854/4/be/src/exprs/aggregate-functions-ir.cc@611 PS4, Line 611: src.val != src.val > In light of IMPALA-6527 I revisited this code. Is it possible for the compi I would certainly hope there aren't any compilers that would optimize this away, since doing so would change the behavior of the program, but I'm not sure. The note on that page seems to indicate that this is a valid way of testing for nan, and we have tests that should (hopefully) catch it if it turns out not to be. I don't see any harm in making the change, though, if you're worried about it. -- To view, visit http://gerrit.cloudera.org:8080/8854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81 Gerrit-Change-Number: 8854 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 20 Feb 2018 23:57:59 +0000 Gerrit-HasComments: Yes
