Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9371 )
Change subject: IMPALA-6549: Enable file handle cache by default ...................................................................... Patch Set 1: (1 comment) > (1 comment) > > > (1 comment) > > > > Do you have a list of tests you plan to run? > > I ran core tests with no issues. This will get incorporated into > the next run of performance tests. Separately, I plan to do a > warmup test where I run with a table with a large number of files > with a cold cache. > And the goal of the warmup test be to determine whether IMPALA-6364 is a problem in the cache miss case, is that right? http://gerrit.cloudera.org:8080/#/c/9371/1/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/9371/1/be/src/runtime/io/disk-io-mgr.cc@109 PS1, Line 109: 21600 > This is a good point. The concern for aging out file handles was about disk Maybe incorporate some of that context into the comment? -- To view, visit http://gerrit.cloudera.org:8080/9371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6935825a1c4c7b2da0bb877f732027be1a57a8b7 Gerrit-Change-Number: 9371 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Feb 2018 00:12:10 +0000 Gerrit-HasComments: Yes
