Dan Hecht has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9401 )

Change subject: IMPALA-6564: avoid scanner thread race leading to query failure
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9401/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9401/2//COMMIT_MSG@13
PS2, Line 13: cause adding new scan ranges to fail with status CANCELLED.
I don't follow this given this code:

 // Case 4. We have not issued the initial ranges so don't start a scanner 
thread.
  // Issuing ranges will call this function and we'll start the scanner threads 
then.
  // TODO: It would be good to have a test case for that.
  if (!initial_ranges_issued_) return;



--
To view, visit http://gerrit.cloudera.org:8080/9401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1a17b8a3586a2f41988f3da673addf2b4565408
Gerrit-Change-Number: 9401
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 20:26:55 +0000
Gerrit-HasComments: Yes

Reply via email to