Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9227 )

Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option
......................................................................


Patch Set 8: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9227/7/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/9227/7/be/src/service/impala-server.cc@992
PS7, Line 992:
> I made the naming of the variables consistent - exec_time_limit_s and idle_
yea that makes sense


http://gerrit.cloudera.org:8080/#/c/9227/8/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/9227/8/be/src/service/impala-server.cc@1855
PS8, Line 1855:           // Query was deleted or expired already.
maybe add: "or expired already from a previous expiration event"


http://gerrit.cloudera.org:8080/#/c/9227/8/be/src/service/impala-server.cc@1894
PS8, Line 1894: queries_by_timestamp_.erase(expiration_event++);
how about
expiration_event = queries_by_timestamp_.erase(expiration_event);

as per c++11 standard



--
To view, visit http://gerrit.cloudera.org:8080/9227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id81772ee223ffb64746e241027a5a734a811e1b8
Gerrit-Change-Number: 9227
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2018 22:01:01 +0000
Gerrit-HasComments: Yes

Reply via email to