Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 )
Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront ...................................................................... Patch Set 33: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8707/33/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/8707/33/be/src/exec/hdfs-scan-node-base.cc@448 PS33, Line 448: // CANCELLED errors - see IMPALA-6564. > Yeah, those are added from within the scanner code while processing a scan Okay, and I guess in the case we hit this but num_unqueued_files_ has also reached 0. Maybe HdfsScanNodeBase::AddDiskIoRanges() should have: // Otherwise, the request context is already cancelled. DCHECK(!progress_.done()); but okay to leave out if you think it's too much paranoia. -- To view, visit http://gerrit.cloudera.org:8080/8707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia243bf8b62feeea602b122e0503ea4ba7d3ee70f Gerrit-Change-Number: 8707 Gerrit-PatchSet: 33 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Feb 2018 22:50:50 +0000 Gerrit-HasComments: Yes
