Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9408 )

Change subject: IMPALA-5152: Introduce metadata loading phase
......................................................................


Patch Set 1:

(2 comments)

Did not cherry-pick clean. I'm still running the tests.

http://gerrit.cloudera.org:8080/#/c/9408/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java:

http://gerrit.cloudera.org:8080/#/c/9408/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@545
PS1, Line 545:       if 
(havingClause_.contains(Predicates.instanceOf(Subquery.class))) {
There was a conflict here with alias substitution changes that are in master 
but not here in 2.x.


http://gerrit.cloudera.org:8080/#/c/9408/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java:

http://gerrit.cloudera.org:8080/#/c/9408/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@2219
PS1, Line 2219:   private void testDecimalExpr(String expr, Type expectedType) {
There was a conflict here with the patch in master that turns on DECIMAL_V2 on 
by default.



--
To view, visit http://gerrit.cloudera.org:8080/9408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I68d32d5acd4a6f6bc6cedb05e6cc5cf604d24a55
Gerrit-Change-Number: 9408
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Fri, 23 Feb 2018 01:09:08 +0000
Gerrit-HasComments: Yes

Reply via email to