Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9227 )
Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option ...................................................................... IMPALA-6482: add EXEC_TIME_LIMIT_S option This is similar to the QUERY_TIMEOUT_S option and shares most of the implementation. The difference is that the timeout doesn't reset at any point. The time limit is measured from the start of query execution, after the query is admitted, so planning, scheduling and time spent in admission control is not counted towards the time limit. Also fix validation of the related QUERY_TIMEOUT_S option, which previously could ignore invalid input. Testing: Added tests for various permutations: * With and without query_timeout_s set * With and without result fetching keeping the query active Change-Id: Id81772ee223ffb64746e241027a5a734a811e1b8 Reviewed-on: http://gerrit.cloudera.org:8080/9227 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/service/query-options-test.cc M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/ImpalaInternalService.thrift M common/thrift/ImpalaService.thrift M tests/custom_cluster/test_query_expiration.py 10 files changed, 304 insertions(+), 111 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id81772ee223ffb64746e241027a5a734a811e1b8 Gerrit-Change-Number: 9227 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
