Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9418 )

Change subject: IMPALA-6567: ResetMetadataStmt analysis should not load tables.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9418/2/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
File fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java:

http://gerrit.cloudera.org:8080/#/c/9418/2/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@189
PS2, Line 189: testResetMetadataStmts
Just curious, whats the naming convention for frontend unit test names? We seem 
to be using names starting with capitals in multiple other places.

grep -rn "@Test" -A 1 fe/src/test



--
To view, visit http://gerrit.cloudera.org:8080/9418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7033781ebf27ea53cfd26ff0e4f74d4f242bd1dc
Gerrit-Change-Number: 9418
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 14:55:54 +0000
Gerrit-HasComments: Yes

Reply via email to