David Knupp has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9431 )

Change subject: IMPALA-6570: Support KUDU on SLES12.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9431/2/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/9431/2/bin/impala-config.sh@275
PS2, Line 275:         centos6 | centos7 | debian7 | debian8 | suselinux12 | 
sles12 | ubuntu* )
I'm not sure this is right. DISTRO_VERSION for SP2 and SP3 seems to reliably 
resolve as suse12 on two CDEP deployed clusters.

  impala-sles12sp2-cluster-1:~ # lsb_release -sir
  SUSE 12.2
  impala-sles12sp2-cluster-1:~ # DISTRO_VERSION="$(lsb_release -sir 2>&1)"
  impala-sles12sp2-cluster-1:~ # DISTRO_VERSION="$(tr -d ' \n' <<< 
"$DISTRO_VERSION" | cut -d. -f1 | tr "A-Z" "a-z")"
  impala-sles12sp2-cluster-1:~ # echo $DISTRO_VERSION
  suse12

and:

  impala-sles12sp3-cluster-1:~ # lsb_release -sir
  SUSE 12.3
  impala-sles12sp3-cluster-1:~ # DISTRO_VERSION="$(lsb_release -sir 2>&1)"
  impala-sles12sp3-cluster-1:~ # DISTRO_VERSION="$(tr -d ' \n' <<< 
"$DISTRO_VERSION" | cut -d. -f1 | tr "A-Z" "a-z")"
  impala-sles12sp3-cluster-1:~ # echo $DISTRO_VERSION
  suse12



--
To view, visit http://gerrit.cloudera.org:8080/9431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3adf17cafda6e3bb1d760f2a8f585bcda540cf9f
Gerrit-Change-Number: 9431
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Feb 2018 20:05:55 +0000
Gerrit-HasComments: Yes

Reply via email to