Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9428 )
Change subject: IMPALA-6537: Add missing ODBC scalar functions ...................................................................... IMPALA-6537: Add missing ODBC scalar functions This patch contains the following builtin function changes: New aliases for existing functions: - LEFT() same as STRLEFT() - RIGHT() same as STRRIGHT() - WEEK() same as WEEKOFYEAR() New functions: - QUARTER() - MONTHNAME() Refactors: - Remove TimestampFunctions::DayName and add LongDayName to match pattern of TimestampFunctions::ShortDayName Additionally, it adds the unit of QUARTER to EXTRACT() and DATE_PART() Testing: - manual testing comparing the translated ODBC functions to the non-translated ones - added at least one new expr-test for aliases - new expr-tests added for new functions Change-Id: Ia60af2b4de8c098be7ecb3e60840e459ae10d499 Reviewed-on: http://gerrit.cloudera.org:8080/9376 Reviewed-by: Alex Behm <alex.b...@cloudera.com> Tested-by: Impala Public Jenkins Reviewed-on: http://gerrit.cloudera.org:8080/9428 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Tim Armstrong <tarmstr...@cloudera.com> --- M be/src/exprs/expr-test.cc M be/src/exprs/timestamp-functions-ir.cc M be/src/exprs/timestamp-functions.cc M be/src/exprs/timestamp-functions.h M be/src/exprs/udf-builtins-ir.cc M common/function-registry/impala_functions.py M common/thrift/Exprs.thrift M fe/src/main/cup/sql-parser.cup M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java M fe/src/test/java/org/apache/impala/analysis/ParserTest.java 10 files changed, 108 insertions(+), 53 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/9428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: merged Gerrit-Change-Id: Ia60af2b4de8c098be7ecb3e60840e459ae10d499 Gerrit-Change-Number: 9428 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
