Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9439 )

Change subject: IMPALA-6565: Fix dropped status in DequeueDeferredRpc()
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9439/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9439/1//COMMIT_MSG@14
PS1, Line 14: aand
> nit: typo
Done


http://gerrit.cloudera.org:8080/#/c/9439/1/be/src/runtime/krpc-data-stream-sender.cc
File be/src/runtime/krpc-data-stream-sender.cc:

http://gerrit.cloudera.org:8080/#/c/9439/1/be/src/runtime/krpc-data-stream-sender.cc@309
PS1, Line 309: if (UNLIKELY(!status.ok())) 
COUNTER_ADD(parent_->rpc_failure_counter_, 1);
> Does this mean a RPC failed? Couldn't a bad RPC response also end up increm
Yes, this is the sum of RPC failure and number of times remote replies with a 
non-retryable error. Comments updated. This helps identify if the error from a 
receiver propagates correctly to the sender.


http://gerrit.cloudera.org:8080/#/c/9439/1/be/src/runtime/krpc-data-stream-sender.cc@627
PS1, Line 627: eos_sent_counter_
> What's the use case for counting this? In the good case this should be equa
To pinpoint senders which didn't send EOS, leading to hung receivers.



--
To view, visit http://gerrit.cloudera.org:8080/9439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b2985a47021ebd4a970861040e7474aca7941b5
Gerrit-Change-Number: 9439
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Feb 2018 02:54:13 +0000
Gerrit-HasComments: Yes

Reply via email to