Dan Hecht has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9439 )

Change subject: IMPALA-6565: Fix dropped status in DequeueDeferredRpc()
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

Please let Sailesh finish his review too, of course.

http://gerrit.cloudera.org:8080/#/c/9439/2/be/src/runtime/krpc-data-stream-recvr.cc
File be/src/runtime/krpc-data-stream-recvr.cc:

http://gerrit.cloudera.org:8080/#/c/9439/2/be/src/runtime/krpc-data-stream-recvr.cc@346
PS2, Line 346:   // TODO: Add timers for time spent in this function and queue 
time in 'batch_queue_'.
is there a counter to determine how many batches made it to this point? If not, 
do you think that would be helpful, given the deferred batch path is 
non-trivial, and that there are error paths that can cause us to not get to 
AddBatchWork()?



--
To view, visit http://gerrit.cloudera.org:8080/9439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b2985a47021ebd4a970861040e7474aca7941b5
Gerrit-Change-Number: 9439
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Feb 2018 05:04:09 +0000
Gerrit-HasComments: Yes

Reply via email to