Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9453 )
Change subject: IMPALA-6586: Fix bug in TestGetTablesTypeTable() ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Seems simple enough to +2. http://gerrit.cloudera.org:8080/#/c/9453/1/fe/src/test/java/org/apache/impala/service/FrontendTest.java File fe/src/test/java/org/apache/impala/service/FrontendTest.java: http://gerrit.cloudera.org:8080/#/c/9453/1/fe/src/test/java/org/apache/impala/service/FrontendTest.java@111 PS1, Line 111: AnalyzesOk("select * from functional.alltypes_view_sub"); I think this could fail again if someone adds a new view to functional schema, but I can't think of a better solution :) http://gerrit.cloudera.org:8080/#/c/9453/1/fe/src/test/java/org/apache/impala/service/FrontendTest.java@124 PS1, Line 124: assertEquals("alltypes_datasource", resp.rows.get(0).colVals.get(2).string_val.toLowerCase()); Not related to your patch, but maybe we can fix the overflow here and below while we are here? Thanks -- To view, visit http://gerrit.cloudera.org:8080/9453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf0bddb2e29209adda5bda5ddc428f46f241c8c9 Gerrit-Change-Number: 9453 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Comment-Date: Tue, 27 Feb 2018 00:17:56 +0000 Gerrit-HasComments: Yes
