Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9455 )
Change subject: IMPALA-6584: Fix TestKuduOperations::test_column_storage_attributes ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/9455/1/tests/query_test/test_kudu.py@359 PS1, Line 359: types = ['boolean', 'tinyint', 'smallint', 'int', 'bigint', 'float', 'double', \ > +1 When I wen't back and looked at the motivation and code path for this test I found their is no difference between the 3 decimal sizes when it comes to column storage attributes. Via the api in this case all of them are just "DECIMAL" DataType. It's worth noting this isn't reducing coverage. I just made a mistake when adding coverage because this test didn't run. If you feel strongly about testing each decimal "size" I can make the suggested change, but I am not sure it adds a lot of test/validation value. -- To view, visit http://gerrit.cloudera.org:8080/9455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7a8c3a07e50e1b7e89192d15380caf8550e4945 Gerrit-Change-Number: 9455 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 27 Feb 2018 00:22:49 +0000 Gerrit-HasComments: Yes
