Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9447 )
Change subject: IMPALA-6512: Maintenace thread period should respect FLAGS_datastream_sender_timeout_ms ...................................................................... IMPALA-6512: Maintenace thread period should respect FLAGS_datastream_sender_timeout_ms Previously, the maintenance thread in KrpcDataStreamMgr will wake up once every 10s to check for early senders which timed out. However, FLAGS_datastream_sender_timeout_ms can be set to a value smaller than 10s. In which case, we may not notice the timed-out senders until much later. This change fixes the problem by changing the wakeup period of the maintenance thread to be min of FLAGS_datastream_sender_timeout_ms/2 and 10000 milliseconds. Also, this change addresses a TODO in the code by moving the check for closed receivers in the 'closed_stream_cache_' from the handler for EOS RPC to the maintenance thread's loop. Testing done: test_exchange_large_delay.py which failed previously when KRPC is enabled. Core debug builds with KRPC enabled. Change-Id: I804cef7cc991007ec44375f8eac804aa2df46bd7 Reviewed-on: http://gerrit.cloudera.org:8080/9447 Reviewed-by: Dan Hecht <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/runtime/data-stream-test.cc M be/src/runtime/krpc-data-stream-mgr.cc 2 files changed, 25 insertions(+), 24 deletions(-) Approvals: Dan Hecht: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I804cef7cc991007ec44375f8eac804aa2df46bd7 Gerrit-Change-Number: 9447 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <[email protected]>
