Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9461 )

Change subject: IMPALA-2567: Enable KRPC by default
......................................................................


Patch Set 2:

(3 comments)

The existing jenkins jobs to test with KRPC enabled will be replaced with tests 
with Thrift enabled.

http://gerrit.cloudera.org:8080/#/c/9461/2/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

http://gerrit.cloudera.org:8080/#/c/9461/2/be/src/runtime/exec-env.cc@83
PS2, Line 83: Used to indicate whether to use KRPC for the "
            :     "DataStream subsystem, or the Thrift RPC layer instead.
> This could be clearer:
Done


http://gerrit.cloudera.org:8080/#/c/9461/2/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/9461/2/bin/run-all-tests.sh@70
PS2, Line 70: if [[ "${TEST_KRPC}" != "false" ]]; then
            :   TEST_START_CLUSTER_ARGS="${TEST_START_CLUSTER_ARGS} --use_krpc"
            : fi
> and this
Done


http://gerrit.cloudera.org:8080/#/c/9461/2/bin/run-all-tests.sh@124
PS2, Line 124: if [[ "${TEST_KRPC}" != "false" ]]; then
             :   COMMON_PYTEST_ARGS+=" --test_krpc"
             : fi
> I think this needs to be adjusted (so we can test with KRPC disabled)
Done



--
To view, visit http://gerrit.cloudera.org:8080/9461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae736c1c1351758969b4d84e34fc5b2d048660a0
Gerrit-Change-Number: 9461
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Mar 2018 18:59:30 +0000
Gerrit-HasComments: Yes

Reply via email to