Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9469 )

Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9469/1/testdata/bin/create-load-data.sh
File testdata/bin/create-load-data.sh:

http://gerrit.cloudera.org:8080/#/c/9469/1/testdata/bin/create-load-data.sh@454
PS1, Line 454: true
I think it would be easier to read if we kept the loop condition here, e.g. 
while [[ $FAIL_COUNT -lt $MAX_RETRIES ]]; then ... and then after the loop 
check if [[ $FAIL_COUNT -eq $MAX_RETRIES ]]; then exit 1;


http://gerrit.cloudera.org:8080/#/c/9469/1/testdata/bin/create-load-data.sh@459
PS1, Line 459: r
Is this the return on success?


http://gerrit.cloudera.org:8080/#/c/9469/1/testdata/bin/create-load-data.sh@462
PS1, Line 462: 6
Can you move this into a variable MAX_RETRIES and re-use that inside the error 
message?



--
To view, visit http://gerrit.cloudera.org:8080/9469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefd4c2fc6c287f054e385de52bdc42b0bdbd7915
Gerrit-Change-Number: 9469
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Mar 2018 23:04:20 +0000
Gerrit-HasComments: Yes

Reply via email to