Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9484 )
Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL ...................................................................... Patch Set 1: I am not 100% sure how to best verify the changes. It looks like the create-load-data.sh script (used by buildall.sh) also loads tpc-h for Kudu but not tpc-ds. It also looks like some kudu create statements are in the standard tpch_schema_template.sql file, but the intention going forward seams to be to used the kudu specific templates for both tpc-h and tpc-ds (according to TODO notes in those files). I tested tpc-h when using buildall.sh to load data and also when using load-tpc-kudu.py to load data. Here is a sample verification script I ran just derived from experimenting: ``` # Load Test Data export JAVA_HOME=/usr/lib/jvm/default-java source bin/impala-config.sh ./buildall.sh -ninja -skiptests -noclean -format -testdata # Load & Run Kudu TCP-DS ./testdata/bin/load-tpc-kudu.py --clean -s tpch -t tpch_kudu -w tpch --kudu_master localhost rm /tmp/None_query_runtime_info.json rm -rf /tmp/profiles/ rm -rf /tmp/result_hashes/ ./tests/stress/concurrent_select.py --minicluster-num-impalads 3 --max-queries=1000 --tpch-kudu-db=tpch_kudu --cancel-current-queries --timeout-multiplier 1000 # Load & Run Kudu TCP-DS ./testdata/bin/load-tpc-kudu.py --clean -s tpcds -t tpcds_kudu -w tpcds --kudu_master localhost rm /tmp/None_query_runtime_info.json rm -rf /tmp/profiles/ rm -rf /tmp/result_hashes/ ./tests/stress/concurrent_select.py --minicluster-num-impalads 3 --max-queries=1000 --tpcds-kudu-db=tpcds_kudu --cancel-current-queries --timeout-multiplier 1000 ``` -- To view, visit http://gerrit.cloudera.org:8080/9484 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f7e4464dc6705cadd610a82c459390a9c0dfe4f Gerrit-Change-Number: 9484 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 03 Mar 2018 02:38:34 +0000 Gerrit-HasComments: No
