Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9339 )
Change subject: IMPALA-6405: Error when string to decimal cast overflows ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9339/2/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: http://gerrit.cloudera.org:8080/#/c/9339/2/be/src/exprs/decimal-operators-ir.cc@584 PS2, Line 584: ctx->AddWarning("String to Decimal cast underflowed"); > Doesn't that mean that the comment for IMPALA-5014: Part 1 isn't doing what IMPALA-5014: Part 1 changes the behavior so that when then there is an underflow, we round instead of truncating when decimal_v2 is enabled. So that patch is correct. Before this patch, underflows happened silently. After this patch we will issue a warning. "Underflow" means that not all digits to the right of the dot in the string could fit into the resulting decimal. "Overflow" means that not all digits to the left of the dot could fit into the resulting decimal. -- To view, visit http://gerrit.cloudera.org:8080/9339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icffccac1c1c2361447ae4b0de9b6c2ec7de071db Gerrit-Change-Number: 9339 Gerrit-PatchSet: 2 Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Mon, 05 Mar 2018 23:08:19 +0000 Gerrit-HasComments: Yes
